search

samvera / hydra-works

A ruby gem implementation of the PCDM Works domain model based on the Samvera software stack
Other
24 stars 14 forks source link

Remove mapping of file_title and file_author #227

Closed grosscol closed 9 years ago

grosscol commented 9 years ago

Fixes #226 Remove custom mapping of file_title and file_author. This will avoid over writing existing title and author values.

jcoyne commented 9 years ago

This is a feature that you are removing. In Sufia you would get to the metadata page and it would have these values entered from the ch18n

grosscol commented 9 years ago

I'm actually reverting to the prior behavior of file_author and file_title instead of author and title. In curation concerns, the FileSet has both a file_author and author method. The file_author is from characterization and author is from the descriptive metadata.

If the method already exists for title and author, characterization will happily use these when assigning values. So if the FileSet had a different title than what ch12n determined from the bitstream, it would get overwritten when ch12n runs.

I am expecting the situation where someone uploads a file which is 'kevin_dataset-new(2)-final.xlsx' but specifies the title as 'final dataset' in the upload form. I would not like 'final dataset' to get overwritten with 'kevin_dataset-new(2)-final.xlsx' or whatever garbage the office application filled in for the title of it's metadata.

mjgiarlo commented 9 years ago

Travis is :unamused:

mjgiarlo commented 9 years ago

@jcoyne Are you :ok: with what @grosscol described?

mjgiarlo commented 9 years ago

:+1: otherwise

jcoyne commented 9 years ago

@mjgiarlo if you're okay, sure.