search

samvera / hydra-works

A ruby gem implementation of the PCDM Works domain model based on the Samvera software stack
Other
24 stars 14 forks source link

Ensure ClamAV scanfile will scan file content. #278

Closed grosscol closed 8 years ago

grosscol commented 8 years ago

Add eicar antivirus testing file as a fixture to support the possibility of writing an integration test, and to have the standard antivirus testing file handy.

Testing the private method calls is not my first choice, but it beat out having an integration test that required actually calling ClamAV. A more robust solution would be to tease apart and recompose detect_viruses in such a way that the behavior is testable without having to call private methods.

Closes #277

grosscol commented 8 years ago

Going to wait for rubocop 0.38.1

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.002%) to 99.045% when pulling 9dfb7f2fcd651ccc131d34ce40172f589798c675 on fix/virus_check into 63130ae5ebbeb2ef0ee24be745cab87c5c605ef0 on master.

escowles commented 8 years ago

:+1: