samvera / hydra-works

A ruby gem implementation of the PCDM Works domain model based on the Samvera software stack
Other
24 stars 14 forks source link

Use plain OM::XML::Document without the datastream #306

Closed awead closed 8 years ago

awead commented 8 years ago

This supports ActiveFedora 11 and removes the dependency on OmDatastream.

awead commented 8 years ago

ping @mjgiarlo @escowles

escowles commented 8 years ago

This looks good to me — the build errors can probably be fixed with: https://github.com/projecthydra/hydra-works/blob/06d5cba043b1bfdb1e7570ec189cc446cc01e3fe/.travis.yml#L9-L10

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.003%) to 99.012% when pulling 0e4a7a1e242eae885e04e8132ca80f2fa5278342 on af-11 into 969eaca67684f96c8f8a4c644144ee23f85fb568 on master.

awead commented 8 years ago

@jcoyne I removed the AF constraint, although I haven't tested this with Sufia master, it should fix the OmDatastream error.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.003%) to 99.012% when pulling 197f41718a778e14d8163a0be16cc522c5ce18c7 on af-11 into 969eaca67684f96c8f8a4c644144ee23f85fb568 on master.

mjgiarlo commented 8 years ago

:clap: