search

samvera / hydra-works

A ruby gem implementation of the PCDM Works domain model based on the Samvera software stack
Other
24 stars 14 forks source link

Removing content read from file input to save memory #320

Closed carolyncole closed 7 years ago

carolyncole commented 7 years ago

This change reverts a small portion of a larger change. https://github.com/projecthydra/hydra-works/commit/6e0dd6cc27ea64af816049b936515a4ef62ddc9b

When you run read it reads the entire content into memory. This is not necessary since the File can be passed directly to Hydra::FileCharacterization

awead commented 7 years ago

@cam156 LGTM. Anyone else?