Fix characterization of audio and video files with Fits 1.2.0

samvera / hydra-works

A ruby gem implementation of the PCDM Works domain model based on the Samvera software stack

Other

24 stars 14 forks source link

Fix characterization of audio and video files with Fits 1.2.0 #341

Closed cjcolvar closed 6 years ago

cjcolvar commented 6 years ago

Fixes #331.

The latest Fits version and many versions before use a different tool (mediainfo) for analysis of audio and video files than was used in prior versions of Fits leading to output with fields in different locations. This PR adds support for the new locations for data while retaining support for the old locations.

Also included in this PR:

Add aspect ratio for newer Fits
Pin activesupport to <5.2 to deal with issues in latest ActiveFedora with Rails 5.2

awead commented 6 years ago

@cjcolvar LGTM. Why all the extra commits in the PR? Does this need a rebase or something?

cjcolvar commented 6 years ago

@awead I could squash if that is preferred.

awead commented 6 years ago

@cjcolvar yeah, squashing is going to look a lot better, but add @yingfeng-iu as a co-author in the commit, so they get credit too. See https://help.github.com/articles/creating-a-commit-with-multiple-authors/

cjcolvar commented 6 years ago

@awead it looks like there is a test ordering bug...I'll try to fix it.