search

samvera / hydra-works

A ruby gem implementation of the PCDM Works domain model based on the Samvera software stack
Other
24 stars 14 forks source link

Replace OM with nokogiri-happymapper #346

Closed jcoyne closed 5 years ago

no-reply commented 6 years ago

Yes, yes, yes!

I'd love to get this in prior to https://github.com/samvera/hydra-works/issues/343.

cjcolvar commented 6 years ago

I'd like there to be more investigation and discussion before this gets merged so we can be very deliberate about our decision. I feel like there is still a fair bit of XML out in the community which is being parsed and generated via OM (within Avalon's ecosystem there definitely is). We still get occasional questions from people trying to work through the XML model lesson (https://github.com/samvera/hydra/wiki/Lesson---Build-a-Codex-model-with-XML). It would be great if we could adopt a single approach for reading and writing across samvera repos then update our documentation accordingly so we can provide some guidance.

This PR seems like one approach. I'd like to see how nokogiri-happymapper works for generating xml especially the tricky scenarios in OM like when you need to generate multiple nodes for a value via templates.

For what its worth nom-xml is another option.

mark-dce commented 5 years ago

@jcoyne are you committed to the happymapper solution? OR would you be OK with closing this in favor of #354 as a solution to removing the OM dependency without introducing an alternative dependency?

jcoyne commented 5 years ago

I don't care. The main goal was to get rid of OM. if #354 does that 👍

mark-dce commented 5 years ago

@jcoyne thanks! I'm gonna close this for now then.