Closed ShanaLMoore closed 2 weeks ago
3 files ±0 3 suites ±0 16m 25s :stopwatch: +38s 1 753 tests ±0 1 720 :white_check_mark: - 3 30 :zzz: ±0 3 :x: +3 1 772 runs ±0 1 737 :white_check_mark: - 3 32 :zzz: ±0 3 :x: +3
For more details on these failures, see this check.
Results for commit 7fa2bc06. ± Comparison against base commit 0c5793b6.
:recycle: This comment has been updated with latest results.
I'm putting this back in draft to confirm if the failures are legit.
Before this commit, adding sharing to a collection would result in an error. The form was sending the value of "false" instead of the selected access.
Issue:
BEFORE
Failed silently and did not add selections to the form. This is because access params was set to false instead of the actual selected value.
#<ActionController::Parameters {"access_grants_attributes"=>#<ActionController::Parameters {"0"=>#<ActionController::Parameters {"access"=>"false", "agent_id"=>"registered", "agent_type"=>"group"} permitted: true>} permitted: true>} permitted: true>
https://github.com/scientist-softserv/palni_palci_knapsack/assets/84697174/d6c4b44e-c6ae-435d-9090-aa2973361bc0
AFTER