search

samvera / hyku

Hyku: A multi-tenant Hyrax application built on the latest and greatest Samvera community components. Brought to you by the Hydra-in-a-Box project partners and IMLS; maintained by the Hyku Interest Group.
https://samvera.atlassian.net/wiki/spaces/hyku/overview
Other
94 stars 46 forks source link

Branding fixes #2244

Closed laritakr closed 2 weeks ago

laritakr commented 2 weeks ago

Story

Fixes https://github.com/scientist-softserv/hykuup_knapsack/issues/205

Expected Behavior Before Changes

Alt text did not work correctly for collection thumbnails and banner. Default collection image did not get used... default work image was used instead.

Expected Behavior After Changes

Notes

github-actions[bot] commented 2 weeks ago

Test Results

    3 files  ±0      3 suites  ±0   16m 50s :stopwatch: +23s 1 753 tests ±0  1 720 :white_check_mark:  - 1  30 :zzz: ±0  3 :x: +1  1 772 runs  ±0  1 737 :white_check_mark:  - 1  32 :zzz: ±0  3 :x: +1 

For more details on these failures, see this check.

Results for commit f02b90b3. ± Comparison against base commit 673ddebb.

This pull request removes 26 and adds 26 tests. Note that renamed tests count towards both. ``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 52ecb378-e81a-4a92-9af0-1f1605d86ad0 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 9d91a1aa-c283-474b-a58a-daaa84cab901 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 2b91353e-c268-412d-b81a-4ed6bce1d2e6 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update d6e29257-93e2-482c-9446-271333b1ada9 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy b84b1225-3d6b-4762-95a4-726abe7c0652 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 68f5eaf9-1e54-40b2-ae20-7ec639ed1d49 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to read f64f011b-eb9f-43af-9abf-dc9612a2ad81 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to update 7188e78f-616b-468a-b16e-2942d2ae6bf6 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to destroy 05139ed4-126e-41d3-be96-059ad59d8973 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to edit 3e94eeb8-b9bc-4254-ab4d-e95fcd73c0a7 … ``` ``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 9a11f888-c31b-4436-8874-f22aa79b8915 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 18822093-be6c-4be3-ac10-be187a891bcc spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read ec670e28-b9db-4619-b81d-1ef5853c2745 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 75c42d07-022d-46d7-960a-14a5bd574611 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy c9295f89-ab98-4577-9813-8331a566ecfc spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit b809d107-6da3-4dc8-a34e-c6198a244e6f spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to read 53a03893-6b80-469a-a121-c4553a7dc77a spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to update d6838baf-7b5d-4f86-9332-c8d767cd3f21 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to destroy 2529a111-b89d-44f2-9a6d-d40c7aa87342 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Image permissions is expected not to be able to edit 2859bcdf-f139-449f-af44-ead4a37d8757 … ```

:recycle: This comment has been updated with latest results.

ShanaLMoore commented 2 weeks ago

spec/tasks/rake_spec.rb:96 is failing for me locally. I'll see if I can sort it out.

laritakr commented 2 weeks ago

spec/tasks/rake_spec.rb:96 is failing for me locally. I'll see if I can sort it out.

Yeah my attempted fix didn't fix. But it is still a random failure the majority of the time as is... Wondering if we should just comment those out?

ShanaLMoore commented 2 weeks ago

spec/tasks/rake_spec.rb:96 is failing for me locally. I'll see if I can sort it out.

Yeah my attempted fix didn't fix. But it is still a random failure the majority of the time as is... Wondering if we should just comment those out?

I reverted the attempted fix and it passed for me locally. I'll still merge it if it still fails on the CI. Perhaps we can comment them out but I'd want to dig into it a little more since I don't remember rake task specs being flaky before.

laritakr commented 2 weeks ago

The rake task has been flaky for me with almost every PR (it's a failure on main as well). It passes for me locally as well, so I don't know how to fix it.

laritakr commented 2 weeks ago

That large files job is also a flaky spec. :/