samvera / hyku

Hyku: A multi-tenant Hyrax application built on the latest and greatest Samvera community components. Brought to you by the Hydra-in-a-Box project partners and IMLS; maintained by the Hyku Interest Group.
https://samvera.atlassian.net/wiki/spaces/hyku/overview
Other
96 stars 47 forks source link

πŸ› [i70] - Removes Show PDF options as form input fields #2247

Closed ShanaLMoore closed 3 months ago

ShanaLMoore commented 3 months ago

Show PDF Viewer and Show PDF Download Button should not render input fields on the work's form.

Issue:

BEFORE

image

AFTER

![image](https://github.com/samvera/hyku/assets/10081604/b3ff01ce-8a34-4f9f-9df3-55126a1de016)
ShanaLMoore commented 3 months ago

UPDATE: FIX error caused when visiting work > edit

Screenshot 2024-06-20 at 08-17-31 Action Controller Exception caught

github-actions[bot] commented 3 months ago

Test Results

β€‡β€ˆβ€‡β€‡3 files  Β±0β€‚β€ƒβ€‡β€ˆβ€‡β€‡3 suites  Β±0   19m 44s :stopwatch: + 2m 14s 2β€ˆ027 tests Β±0  1β€ˆ982 :white_check_mark:  -β€Š1  44 :zzz: Β±0  1 :x: +1  2β€ˆ054 runsβ€Š Β±0  2β€ˆ007 :white_check_mark:  -β€Š1  46 :zzz: Β±0  1 :x: +1 

For more details on these failures, see this check.

Results for commit e6a8c7db. ± Comparison against base commit be25615f.

This pull request removes 43 and adds 43 tests. Note that renamed tests count towards both. ``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy b498e0e4-2489-4aa1-8520-98e947ee5bab spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit e786648d-9955-4426-b7c3-10dde5ab3cd3 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 815e2320-e86e-4fe6-beb9-a8f874715bcd spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update b1c5b819-cccf-4633-8287-8db4e2aaee1e spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 46c4e8d2-9705-4bd7-97c8-3bb30a9e587a spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit f864138c-baeb-43e0-bc3e-c35923e2faa0 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read e864d2e8-f7d1-448b-ae12-8b68398d660b spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 9aa6a1a1-d326-47dd-ad20-46285dd366ef spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 11bb7243-02f1-4124-9648-82afac9d9aae spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 1a37960b-5317-47fd-b4ca-51220a028588 … ``` ``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy bcdda597-a471-4e0a-92f0-f70ed83e0578 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 3fc9eb0f-c2e0-4e8b-aa95-ee6cfe2d2c33 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read cfe2d579-5677-441e-9ec3-c14ef619c539 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update d8421dbf-6027-4950-b26c-cf747871d0b9 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy a61be50f-c5e8-4653-849d-cd108416d563 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit be4b3cd0-5c1a-4e80-9276-f650bf8cb2d7 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read f689211d-515e-44ad-b0c0-b28c3d39ed46 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update c18b8365-79a8-425c-bd37-604a4c7387a7 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 2dae18a9-d68a-402c-b40a-9e13f91976fd spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 95187439-547a-4757-ad8a-232c4b7a53ae … ```

:recycle: This comment has been updated with latest results.

ShanaLMoore commented 3 months ago

UPDATE: FIX error caused when visiting work > edit

Screenshot 2024-06-20 at 08-17-31 Action Controller Exception caught

resolved:

image