ShanaLMoore
commented
1 month ago @bkiahstroud
I pushed up a fix for rubocop. Hopefully it'll pass the pipeline soon.
Closed orangewolf closed 1 month ago
ShanaLMoore
commented
1 month ago @bkiahstroud
I pushed up a fix for rubocop. Hopefully it'll pass the pipeline soon.
Test Results
3 files ±0 3 suites ±0 17m 37s :stopwatch: -10s 2 024 tests - 3 1 974 :white_check_mark: - 9 50 :zzz: +6 0 :x: ±0 2 051 runs - 3 1 999 :white_check_mark: - 9 52 :zzz: +6 0 :x: ±0
Results for commit ad2ef65d. ± Comparison against base commit 7fff868a.
This pull request removes 45 and adds 42 tests. Note that renamed tests count towards both.
``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 1dc69889-6eea-4fb4-bf59-572f2081b382 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit d53aecdf-1b0f-42ba-836f-b4621a54ff6b spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 9f875a21-4cd1-480e-b57c-df621bde9292 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 0d0226e6-7a3a-4197-b0da-bfbfebd5995a spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 334d245d-cad7-4886-8bf5-68d9dfc9ab92 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 43cbaf7c-138a-4168-8f8a-b684d9307619 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 389d5394-1454-4bb6-8969-f4b57abdca12 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 3ef3f335-99e2-4865-beba-03c692a9a801 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 12f14921-d918-469c-9804-cc6324d2fb20 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 0972616e-12e6-4215-8448-d4a6fcab71fe … ``` ``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 83f89d78-687e-4feb-93b3-01fbf8c1aaf2 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit a2257241-3f79-4057-9ffa-03b67d55dfc3 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 76879e02-edb8-4cc1-98d3-c849c98a0af0 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 634fc9b8-dc1c-41b6-bb69-21da10a8de89 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 42b83a46-e54e-40af-bd92-bfa25513b1a2 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 6f7d8fa6-1252-40e8-8002-9b18a227b2f6 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 977c91da-b152-4db1-a833-f47956137345 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update bba62087-eacd-4eef-8795-dd4592c86ebc spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 98ca4590-4d83-4a78-91e1-538de97009bd spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 00dabe8b-4aa3-407f-a3ba-db0792b558c6 … ```This pull request skips 6 tests.
``` spec.parsers.bulkrax.csv_parser_decorator_spec ‑ Bulkrax::CsvParserDecorator#valid_import? when all required fields are present returns true spec.parsers.bulkrax.csv_parser_decorator_spec ‑ Bulkrax::CsvParserDecorator#valid_import? when required fields are missing rescues the error and calls set_status_info spec.parsers.bulkrax.csv_parser_decorator_spec ‑ Bulkrax::CsvParserDecorator#valid_import? when required fields are missing returns false spec.parsers.bulkrax.csv_parser_decorator_spec ‑ Bulkrax::CsvParserDecorator#valid_import? when the csv header is a sequential number still returns true spec.parsers.bulkrax.csv_parser_decorator_spec ‑ Bulkrax::CsvParserDecorator#valid_import? when the csv header is the parser_mappings value still returns true spec.parsers.bulkrax.csv_parser_decorator_spec ‑ Bulkrax::CsvParserDecorator#valid_import? when the csv headers are in any case (capitalized or lowercased) still returns true ```:recycle: This comment has been updated with latest results.