samvera / hyku

Hyku: A multi-tenant Hyrax application built on the latest and greatest Samvera community components. Brought to you by the Hydra-in-a-Box project partners and IMLS; maintained by the Hyku Interest Group.
https://samvera.atlassian.net/wiki/spaces/hyku/overview
Other
94 stars 46 forks source link

Propagate locale between group form tabs #2262

Closed bkiahstroud closed 5 days ago

bkiahstroud commented 5 days ago

Ref:

This is a UX improvement. However, it also fixes a bug where some users were getting an error message on these pages for the locale param being an empty string (?locale=). Strangely, this only appeared to be affecting users using Windows, but that may not be causation.

Edit Group Administration Hyku Commons 2024-06-27 at 5 21 28 PM


Originally implemented in PALNI/PALCI's Hyku:

@samvera/hyku-code-reviewers

github-actions[bot] commented 5 days ago

Test Results

    3 files  ±0      3 suites  ±0   18m 26s :stopwatch: +55s 2 027 tests ±0  1 977 :white_check_mark: ±0  50 :zzz: ±0  0 :x: ±0  2 054 runs  ±0  2 002 :white_check_mark: ±0  52 :zzz: ±0  0 :x: ±0 

Results for commit a6570c75. ± Comparison against base commit e7ac989e.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both. ``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 61f8a8c7-62e2-4c8a-9e02-6aa84e9d80bb spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit e15e2a75-26cb-487b-af8c-1fec94076a3f spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 09b8a37e-d7c1-4710-989f-2a80e5b57735 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 1b3bc16d-d8b5-4048-90f4-490e191186da spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 541fbf95-5ff0-43eb-a3ee-74949af7d329 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 43f19f0f-a765-410d-b6a9-8c140bfec7e3 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 3e8748c2-8317-470b-ad7e-1a01e0d981a4 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 4827733f-23d3-4b94-a40c-3c06828a78a4 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 06864e16-a926-4ff8-bfc2-f7112f815433 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit b0eeb7ad-feea-4cce-9d92-32f1777d115e … ``` ``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy ad7e5d1b-5a5a-4805-bef1-d639f362953f spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit e3a3da0b-ddc0-4acd-9b16-f06278553814 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 292b91f1-b507-4157-80c7-b3926d443856 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 97e09a8e-b013-4280-bf27-2c1379a1ab98 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 16dbdb32-23a3-4e6d-bff0-7900e7a2c999 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit f147f79e-1d44-43eb-bdfa-14afaae2a22a spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 12f18f6d-b9a5-4742-8c51-0f8ea129723f spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 66f91f5a-ac6f-4477-a5db-ffcfa69de6cf spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 518eb2e3-98cb-47d9-8742-ff5cd7a0dcd3 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit edc3d3e1-e4e2-456f-8796-c0369eb9218d … ```