samvera / hyku

Hyku: A multi-tenant Hyrax application built on the latest and greatest Samvera community components. Brought to you by the Hydra-in-a-Box project partners and IMLS; maintained by the Hyku Interest Group.
https://samvera.atlassian.net/wiki/spaces/hyku/overview
Other
96 stars 49 forks source link

Themes logic refactor #2284

Closed kirkkwang closed 3 months ago

kirkkwang commented 3 months ago

Summary

♻️ Add Hyku::HomePageThemesBehavior

2ba8794749b0dff8fb3ad04104ab66d2f07e02b6

This commit will move the #inject_theme_views method and the around_action that calls it into a concern.

πŸ› Use unshift instead of push

94d495664bffa79804aa4c6c75c59671829454f5

In the HykuKnapsack, we want the themes view path to be prioritized over the Hyku application's themes view path.

github-actions[bot] commented 3 months ago

Test Results

β€‡β€ˆβ€‡β€‡3 files  Β±0β€‚β€ƒβ€‡β€ˆβ€‡β€‡3 suites  Β±0   17m 58s :stopwatch: +12s 2β€ˆ030 tests +6  1β€ˆ980 :white_check_mark: +6  50 :zzz: Β±0  0 :x: Β±0  2β€ˆ057 runsβ€Š +6  2β€ˆ005 :white_check_mark: +6  52 :zzz: Β±0  0 :x: Β±0 

Results for commit 94d49566. ± Comparison against base commit 835bb981.

This pull request removes 42 and adds 48 tests. Note that renamed tests count towards both. ``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 99c135b6-0ffa-4cf2-8d8e-7d858467d70e spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit f1a7d11c-0f4f-4af0-b39f-c727e0785e23 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read b68dfa92-f97d-48db-af43-81a9b3f639d3 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 8e8b8ffd-ad94-4bc0-a33b-1a74f9bf63bf spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy bd5e9705-1b4c-4388-895d-bb00e1ffc592 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 3ba247b4-adcd-47e4-9780-493e85b63090 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read fcf39070-f1fa-4fa7-9b0c-ebbb0b8c365e spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 30ba8515-1eef-4373-a930-80d67cc79efc spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy b6a2e164-5030-4d86-b269-e1fe8c25024f spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit aa96bd4d-2076-4dc2-93fa-e68f668e22bb … ``` ``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy c2b5448c-def1-4048-8c0a-600df79f9837 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 72ebccab-c69e-40b1-a8ac-4f5147b38a0d spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read bac93702-9196-48b5-9ad8-b4a8e8416c66 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update a40ddd14-fb8c-4719-a565-0255fbf209af spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy a9f60b52-7b8a-4d50-b13b-a46bb4ad39fc spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit ddc7f21c-dff8-42ae-b286-ae9d698a0f0b spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 11b1d996-7268-4b7c-a7e5-860f4eea86eb spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update c22387bc-21aa-44df-893d-0ede8a42de71 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 3d8ae4ab-9254-458b-8de6-daf73e4dcf36 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit e3d00292-ad81-4a10-95df-998870d95f08 … ```