samvera / hyku

Hyku: A multi-tenant Hyrax application built on the latest and greatest Samvera community components. Brought to you by the Hydra-in-a-Box project partners and IMLS; maintained by the Hyku Interest Group.
https://samvera.atlassian.net/wiki/spaces/hyku/overview
Other
96 stars 49 forks source link

Fix Admin Set form to make edit work #2292

Closed laritakr closed 3 months ago

laritakr commented 3 months ago

include CollectionAccessFiltering was happening at the wrong time, and a needed method was not found by the edit view. This presented the lazy migration from happening for the admin set in the UI, but saving the resource in the console created a slightly broken valkyrized resource.

This PR fixes the edit, and the converted admin sets appear for use when creating a work via the UI or Bulkrax.

ShanaLMoore commented 3 months ago

@laritakr Does this mean Katharine is free to start QAing? (after the merge and submodule updates of course)

laritakr commented 3 months ago

@laritakr Does this mean Katharine is free to start QAing? (after the merge and submodule updates of course)

Yes, I believe this should unblock QA

github-actions[bot] commented 3 months ago

Test Results

    3 files  ±0      3 suites  ±0   18m 15s :stopwatch: +8s 2 030 tests ±0  1 980 :white_check_mark: ±0  50 :zzz: ±0  0 :x: ±0  2 057 runs  ±0  2 005 :white_check_mark: ±0  52 :zzz: ±0  0 :x: ±0 

Results for commit 0ac68adb. ± Comparison against base commit a81292fc.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both. ``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 18ebd59c-c46e-4099-8212-e1e1d7f3dd79 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit c5c95a23-a720-4ef4-8a8c-3ed5ac094daa spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 47001562-48ef-4ed1-accd-1964e4f3a863 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 4b3612f0-33c1-4bd4-9576-da2c51c205a5 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 2e6e5d4f-07a0-4717-b4cc-a01245603741 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit f9511dd2-03d3-4f66-ba03-488711fd04dd spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 1fd3e2f1-b183-49fe-8610-b59d540b263f spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 1280c4a3-0926-4e29-a603-6c8640dfdd05 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 4800d7b2-9ea5-4d3e-b0c0-178f29c5456e spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 2067fa51-a691-43f3-a53c-13b547952d8b … ``` ``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 0264dc2f-2a62-45c6-87f1-c4c4094d3ff4 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit f6d2787e-fc86-4012-b1de-d0b58961a9a3 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read bcad733c-a7fd-46f0-bd12-e78c24bd5c04 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 4d907990-f45c-4c97-886a-9c771ef24e38 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 454a5e59-d83e-4699-8541-44a80ea3310e spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 65fbf84c-c5c1-4666-903a-f503fdc074d0 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read eb3f16a1-ef88-4b2e-9bd7-41439896d6ea spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 61983edb-dff4-463a-806a-fe8971313cb0 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy a200e0a9-81d1-407a-a2f9-e71e1e266ad8 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 772384e5-64e5-46dd-8deb-31b653699e83 … ```