samvera / hyku

Hyku: A multi-tenant Hyrax application built on the latest and greatest Samvera community components. Brought to you by the Hydra-in-a-Box project partners and IMLS; maintained by the Hyku Interest Group.
https://samvera.atlassian.net/wiki/spaces/hyku/overview
Other
96 stars 49 forks source link

Update Hyrax to fix underlying based near #2360

Closed laritakr closed 1 month ago

laritakr commented 1 month ago

Updates Hyrax to bring in based near fix Removes decorator which broke the form UI and is now unneeded. Screenshot below shows the location interface now is opened on an empty form.

Screenshots after change ![Screenshot 2024-10-16 at 4 12 30 PM](https://github.com/user-attachments/assets/00094357-7754-45a8-8ff8-608cc050d5a5) ![Screenshot 2024-10-16 at 4 12 24 PM](https://github.com/user-attachments/assets/1f024488-cc56-40a8-9247-758861139de4)

@samvera/hyku-code-reviewers

github-actions[bot] commented 1 month ago

Test Results

    3 files  ±0      3 suites  ±0   17m 47s :stopwatch: -1s 2 038 tests ±0  1 988 :white_check_mark: ±0  50 :zzz: ±0  0 :x: ±0  2 065 runs  ±0  2 013 :white_check_mark: ±0  52 :zzz: ±0  0 :x: ±0 

Results for commit fd671cd5. ± Comparison against base commit 69b3e600.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both. ``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy b3818bb5-fbea-4e0b-96d7-74894b9969c3 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 45b27883-5683-4565-80d1-13b5d7dfff4e spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 5a2ebe20-6d3a-4e80-a626-b6a363448ead spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 58fec845-8f70-44e4-9917-22d3245c0262 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 2dd63ee3-1413-4ad9-91ec-48c9f9f33d66 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit a93f7aaa-9f94-4fda-b24b-988eb8829857 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 3bb20e06-5fe8-478c-82b2-6c0367d68167 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 470e83de-e4b8-47b9-bd9b-1afca3f491ba spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy ea58afb7-e69a-4b6f-8075-5b69068aa89b spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 32649a72-cf51-44a4-abb8-481582ba3cd3 … ``` ``` spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy fcff542b-a4f5-4ace-a0f1-45b99bc8f0ed spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 746d1751-9e4d-4895-86aa-f993879be0b7 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read f1eae7e4-96a9-491c-af79-c038f83bd279 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 71f4dec1-a597-4d34-9711-5df2610011a2 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 32c50686-421e-4c63-a319-b78cf0a5abf4 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 4a10d98e-bedc-46a9-b0f5-f61c60592698 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read ee2ace08-533c-4c6c-9690-78f612be4984 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update f60ceb22-cb32-4b1c-af34-3ce7ad71b72d spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy d274320b-c04c-4d7e-acc5-4820485ba930 spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit e3663b0b-d197-44d9-8448-2e5e74da73db … ```

:recycle: This comment has been updated with latest results.