search

samvera / hyku

Hyku: A multi-tenant Hyrax application built on the latest and greatest Samvera community components. Brought to you by the Hydra-in-a-Box project partners and IMLS; maintained by the Hyku Interest Group.
https://samvera.atlassian.net/wiki/spaces/hyku/overview
Other
94 stars 47 forks source link

Mockup: Configuration > Settings > General #438

Open ggeisler opened 7 years ago

ggeisler commented 7 years ago

Change current menu item Configuration > Settings > Labels to Configuration > Settings > General, where the General page has tabs for distinct sets of general repository settings:

Labels tab

(TBD: strategy for indicating required fields that is more restrained than is currently in Sufia.)

labels-tab

Analytics tab

So, at least (only) an input for entering the GA key/ID

Other tabs

TBD. No current need for Notifications or Repo Objects tabs. Mockup to be revised.

mjgiarlo commented 7 years ago

@jcoyne @hannahfrost @ggeisler Do you think this design is good to go? I believe analytics support is required for MVP.

ggeisler commented 7 years ago

@mjgiarlo Technically this was still in the Design Needed column (until you moved it to Ready a few hours ago) because the design was not complete ("Mockup to be revised"). It had not been prioritized near the top of the Design Needed queue so I didn't know this should take priority over other issues. I'm concerned that @hannahfrost and I developed what seems to be a decent structured requirements and design process, but that this process is either not understood or respected by the rest of the team (cf. the whole debate last week about the implementation of the select work type for batch upload).

That said, if you're looking for tickets for developers to work on, this is probably fine without further design. Based on comments I made above, the Analytics tab should have a labeled input field for a GA ID, and unlike the mockup, there appears to be no need for the Notifications or Repository Objects tabs. Seems straightforward enough. (I would have just preferred that this had been elevated to the top of the design needed queue earlier so I could have provided a finished mockup, trivial as the updates might be.)

mjgiarlo commented 7 years ago

@ggeisler I was tweaking labels here in GitHub -- I didn't realize that adding HyBox ready would override design needed. Should have double-checked in Waffle after I made that change. We have a fine process, and I doubt anyone is intentionally undermining it; it's more that we're working on a complex project with a lot of moving parts across a number of different codebases. I've undone that change. Sorry for that.

ggeisler commented 7 years ago

No problem, @mjgiarlo. I don't mean to make a big deal about it. I do understand this is a complex project and we're never going to have as smooth a process as we have had on smaller projects. I just want to prioritize my HyBox time to provide the best benefit to the project and it seems hard to get a handle on what that is sometimes.

mjgiarlo commented 7 years ago

@ggeisler Absolutely, @ggeisler. I suspect we need to spend more time on team coordination in the new year; we will all benefit from that. Our sprint planning has become more loosey-goosey than it probably ought to be.

hannahfrost commented 7 years ago

At this stage, we are deprioritizing analytics from the MVP scope. (Lots of good work done towards spec'ing it and the tasks to make it happen, so we can pick it up soon.) Given that, let's implement the design shown in this mockup but just with the one tab: General. We'll add Analytics when we are ready to implement that functionality.

Sound good, @ggeisler @mjgiarlo ?

mjgiarlo commented 7 years ago

Sounds good, @hannahfrost!

ggeisler commented 7 years ago

Sounds fine to me. But note that we can probably just leave the tab label as it currently is, "Labels," rather than "General."

hannahfrost commented 7 years ago

Revisit this ticket when functionality for the other tabs is ready to be made available.