Open hannahfrost opened 7 years ago
Related to this abandoned Sufia PR: https://github.com/projecthydra/sufia/pull/2026
@mjgiarlo how should we proceed with this?
@jcoyne should we get design before taking this forward?
@mjgiarlo I'm asking if we should take over/replace that sufia pr, or do you think they'll get back to that? It seems like @hannahfrost has some design in mind where the edit page shows the existing files. (which I think was what the Sufia UI group intended).
@jcoyne Yes, we should take over/replace that sufia PR. The person who was working on it no longer works for UVa, AFAIK. Good call, too -- we should roll w/ what the Sufia UI WG designed. I suspect we should do that work in Sufia (so the 7.x folks pick it up). Thanks!
There's very little in that PR except for a table-driven template:
<% f.object.file_sets.each do |file| %>
<tr>
<td>
<span><%= file.solr_document.label %></span>
</td>
<td>
<span><%= file.title %></span>
</td>
</tr>
<% end %>
</tbody>
I don't think we need to use the existing PR at all (it's also marked closed).
When editing an existing work containing file(s), I would expect to see the existing files listed on the Files tab, along with the ability to either delete an existing file or add more file(s). Instead all I see is the ability to add more files