search

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
184 stars 124 forks source link

Multiple work types: broken facets #148

Closed mjgiarlo closed 5 years ago

mjgiarlo commented 7 years ago

Issue by hackmastera Tuesday Aug 09, 2016 at 20:19 GMT Originally opened as https://github.com/projecthydra/sufia/issues/2437

Descriptive summary

On 'My Works' works listing, and on search results, 'filter by work type' groups all work types into the same category, called 'Work'.

Expected behavior

Work types should each have their own facet value.

Steps to reproduce the behavior

  1. Generate a 2nd curation concern using the sufia:work generator
  2. create works of both types
  3. navigate to 'my works' or submit blank search.

    Related work

umbrella ticket is #2199

mjgiarlo commented 7 years ago

Comment by jcoyne Wednesday Aug 31, 2016 at 12:31 GMT

This is not a bug, there are two types of facet needed. One for the general type (e.g. Work, Collection, etc.) The other is for specific type (Book, ETD, etc)

CurationConcerns has both: https://github.com/projecthydra/curation_concerns/blob/master/lib/generators/curation_concerns/templates/catalog_controller.rb#L26 https://github.com/projecthydra/curation_concerns/blob/master/lib/generators/curation_concerns/templates/catalog_controller.rb#L33 I think sufia only has the later.

no-reply commented 6 years ago

Feedback is needed @samvera/hyrax-repo-managers.

vantuyls commented 5 years ago

this cannot be reproduced. likely this has been fixed by other changes since the original issue was submitted.