samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
185 stars 124 forks source link

Collections: Update index to handle bulk actions for collections #1510

Closed elrayle closed 7 years ago

elrayle commented 7 years ago

Descriptive summary

Update index page for All/My Collections to process bulk actions. This is not a dependecny for any other work, so the priority of this issue is low.

NOTE: This issue was extracted from the uber issue for index view changes. #1417

Rationale

See model issue for rationale.

Implementation

Edit Files:

Expected user interactions

From the All Collections and My Collections pages, a user can...

Exact text for the bulk actions drop list is in the mockup below.

Mockup

Bulk delete button is the Delete collections button above the list of collections. See note 2 for details on confirmation dialogs.

collection-index-end-user

Related work

Directly related work...

1655 Include admin sets in collection search builders.

1708 UI/UX question regarding checkboxes for AdminSets on Collections index page

Collections feature Issue
Routes #1380
Controller #
Model #1383
View - Index #1417
Index: Collection List #1509
Index: Filter List #1511
Index: New Modal #1506
Index: Edit Action #1508
Index: Delete Action #1507
Index: Add as Subcollection Action #1512
Index: Bulk Actions (this issue)
View - Show - Admin #1427
View - Show - Landing #1428
View - New/Edit #1374
Partial - Description #1375
Partial - Branding #1376
Partial - Relationships #1377
Partial - Sharing #1378
Partial - Discovery #1379
elrayle commented 7 years ago

@ggeisler Since Delete is the only supported bulk action, should checkboxes be disabled for any collection where the user does not have edit access?

ggeisler commented 7 years ago

@elrayle What is the scenario where a user wouldn't be able to delete a collection that user created? I guess I'm missing something.

elrayle commented 7 years ago

@ggeisler

[Can't delete when] the user does not have edit access

This scenario occurs on Dashboard -> Collections -> Managed Collections, for any collection in the list where the user has view or deposit access, but not manage access.

elrayle commented 7 years ago

UI/UX of Bulk Delete...

@ggeisler Can you select checkboxes for the statements you agree with and add clarifications where you expect things to be different.

Your Collections

Managed Collections

All Collections

ggeisler commented 7 years ago

@elrayle These seem reasonable to me, although you should keep in mind that I'm not running the application so am just going by what makes sense to me on paper. If you or the team actively working on things feel strongly something should be different, feel free to override my opinion.

The one I didn't check in each case has to do with not including the checkbox next to admin sets. I assume this only applies to admin sets that are not empty? In other words, if an admin set is empty, then you would present the checkbox (assuming the user has delete privileges), since the admin set in that case is eligible for deleting.

elrayle commented 7 years ago

Remaining work:

1788 Batch delete should show message if fails

1708 UI/UX question regarding checkboxes for AdminSets on Collections index page

elrayle commented 7 years ago

All requirements are addressed by PR #1788 OR in the issues for remaining work. Closing.