The inactive state of mediated deposit workflow supersedes the visibility settings for the object - Githubissues

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.

http://hyrax.samvera.org/

Apache License 2.0

184 stars 124 forks source link

The inactive state of mediated deposit workflow supersedes the visibility settings for the object #176

Closed mjgiarlo closed 7 years ago

mjgiarlo commented 7 years ago

Issue by blancoj Wednesday Sep 21, 2016 at 17:25 GMT Originally opened as https://github.com/projecthydra/sufia/issues/2728

When mediated deposit is enabled, and a work is in inactive state because it is in the mediated deposit workflow and has not yet been approved, but the work has been marked as visible to other user(s), the work should not be visible by those user(s) and those user(s) should not yet receive a notification that the work is available.

mjgiarlo commented 7 years ago

Comment by mjgiarlo Friday Oct 28, 2016 at 22:18 GMT

@vantuyls and I believe this is a better ticket for CC, since this is not mediated deposit-centric. @jcoyne confirm/deny?

mjgiarlo commented 7 years ago

Comment by mjgiarlo Friday Nov 04, 2016 at 21:57 GMT

@vantuyls Should we defer this to Phase 2, operating under the assumption that Phase 1 is for 0-step?

mjgiarlo commented 7 years ago

Comment by mjgiarlo Monday Dec 05, 2016 at 17:42 GMT

@vantuyls how much do we really care about this one? I'm moving it to phase 2 for now, but it'd be good to see if this is still relevant and highly desired. (I wonder if this can collapse into the "editing an object sends it back through workflow" story?)

mjgiarlo commented 7 years ago

Comment by vantuyls Monday Dec 05, 2016 at 18:19 GMT

If we're sure that the object will remain hidden from view when it is in the workflow, then OK. Otherwise, this needs to be an issue we address explicitly.

mjgiarlo commented 7 years ago

Comment by mjgiarlo Monday Dec 05, 2016 at 18:32 GMT

If user A shares an in-workflow work with user B, the work will be hidden from B in search results and the show view assuming B lacks permission to advance the work from its current workflow state. I'm not sure if it's also hidden from B's dashboard. This would be worth testing/QAing. Might you have cycles for this, @vantuyls?

mjgiarlo commented 7 years ago

@vantuyls Can you find a few minutes to test/QA this to see if it's a problem or not?

vantuyls commented 7 years ago

pinging @scholarworks because i think he'd been seeing bad behavior on this a week or so ago.

jcoyne commented 7 years ago

@vantuyls @scholarworks what's the status of this ticket?

scholarworks commented 7 years ago

@jcoyne going to test/qa this today.

scholarworks commented 7 years ago

Here's what I did:

New test app
Create 3 users: -- Admin -- Depositor -- generic (no roles) -- create default admin set and assign one-step-mediated deposit workflow -- Depositor submits and item and it lands in workflow -- Depositor can no longer edit the item -- Admin logs in and shares (but does not approve) the item with the no role user -- login as no role user, the item isn't viewable or findable. -- log back in as admin and approve -- item is now discoverable.

@vantuyls I believe this ticket can be closed. If I missed a use case, please let me know.

vantuyls commented 7 years ago

@scholarworks thanks! Looks like we're all set.