search

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
184 stars 124 forks source link

Add work to another work (in_works) #325

Closed mjgiarlo closed 7 years ago

mjgiarlo commented 7 years ago

Issue by jcoyne Wednesday Mar 30, 2016 at 21:54 GMT Originally opened as https://github.com/projecthydra/sufia/issues/1709

Descriptive summary

Add the work currently being edited as a member of other works.

Closely related to #1710 Ref #1577

mjgiarlo commented 7 years ago

Comment by jcoyne Wednesday Mar 30, 2016 at 21:54 GMT

@mjgiarlo backlog?

mjgiarlo commented 7 years ago

Comment by jcoyne Thursday Nov 17, 2016 at 17:13 GMT

@dlpierce can you give us an update on the status of this work?

mjgiarlo commented 7 years ago

Comment by mjgiarlo Monday Jan 23, 2017 at 23:39 GMT

@dlpierce We're 1-2 blockers away from cutting a beta/RC for 7.3.0. Do you think you might have time to wrap this and #1710 in the coming week or two?

mjgiarlo commented 7 years ago

Comment by dlpierce Tuesday Jan 24, 2017 at 18:22 GMT

@mjgiarlo Yes, I'll make it a priority to get this done for 7.3.0.

mjgiarlo commented 7 years ago

Remaining work in this ticket:

dlpierce commented 7 years ago

I'm going to use this issue for tracking '"Surface the "This Work in Other Works" and "Other Works in this Work" widgets in the new view.' and leave the other part for #326 .

In the interest of sharing the code for this feature between the new and edit forms, I would like to move from using ajax calls to update child/parent work relationships to performing the update when the Save button is clicked.

Rationale is it's reasonable for a user to expect their changes to not be automatically saved when presented with Save and Cancel buttons. Currently the work relationships will be instantly persisted when the Add or Remove button is clicked, even when there are other changes entered in the work form. Clicking Cancel after making relationship changes will not undo the relationships and clicking Save only persists metadata property changes and file uploads. The timing of the save call was briefly discussed in the original PR of this feature.

As a bonus, making this change should facilitate bringing this feature to the form for a new work.

Any thoughts from @projecthydra-labs/hyrax-code-reviewers ?

mjgiarlo commented 7 years ago

This ticket and #326 should focus on UI changes for the add child/parent feature, now that @jcoyne is about to put in a related PR that removes javascript in favor of handling this in the form (so as not to run afoul of locking issues).

mjgiarlo commented 7 years ago

We found issues with this approach and abandoned it.