search

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
184 stars 124 forks source link

Depositor can't see his submited 'private' work under one-step admin-set #3435

Closed jmfrenzel closed 5 years ago

jmfrenzel commented 5 years ago

Descriptive summary

Hyrax Version: 3.0.0.pre.beta1 Hyrax Branch: master Hyrax Revision: 892c70712350a5583a51ad4c5cfec000d07b75de

Rationale and Expected behavior

Depositor should see all its work including private ones when submitting under one-step deposit admin set during review process, not only after the manager requests a change/approves that work the depositor get immediate access back.

Actual behavior

see https://github.com/samvera/hyrax/issues/3435#issuecomment-440288143 After the manager requests a change/approves that work the depositor get immediate access back.

Steps to reproduce the behavior

as non admin user with depositor rights

  1. submit a new, private work into an one-step admin set

Related work

Link to related tickets or prior related work here.

jmfrenzel commented 5 years ago

onestepdepositprivatework

chrisdaaz commented 5 years ago

verified and related to https://github.com/samvera/hyrax/issues/857

chrisdaaz commented 5 years ago

this also shipped with 2.1 fyi

laritakr commented 5 years ago

I believe this is a nurax issue. I had previously fixed this issue in Hyrax (https://github.com/samvera/hyrax/pull/3161).

When I look at the workflow definition in nurax, it doesn't match the workflow in hyrax:

https://github.com/curationexperts/nurax/blob/master/config/workflows/mediated_deposit_workflow.json#L20-L21

https://github.com/samvera/hyrax/blob/master/lib/generators/hyrax/templates/mediated_deposit_workflow.json.erb#L20-L22

@chrisdaaz @julesies can someone please get this corrected on Nurax and verify if the issue still exists after reloading the workflows?

laritakr commented 5 years ago

I worked with @bess to update the workflows on nurax-dev, and I believe that this is working as expected.

@chrisdaaz or @no-reply can you confirm and close this issue?

screen cap of my test in nurax-dev

screen shot 2019-01-23 at 12 11 47 pm

laritakr commented 5 years ago

Fixed. Requires workflow update to make it work in existing app.