search

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
184 stars 124 forks source link

Firefox and Safari bug in selecting different works to batch edit #356

Open mjgiarlo opened 7 years ago

mjgiarlo commented 7 years ago

Issue by hannahlwang Thursday Feb 02, 2017 at 19:01 GMT Originally opened as https://github.com/projecthydra/sufia/issues/3052

Descriptive summary

I'm at UNC, we're on Sufia 7.2. This problem seems to only happen on Firefox and Safari, Chrome is fine. If you select works in "My Works" and go to the Batch Edit view, then click back in your browser, deselect the selected works, select different works, and go to the Batch Edit view again, it still displays the previously selected works in addition to the newly selected works in "Changes will be applied to". The only way to truly change your selection is to refresh your browser.

Expected behavior

When I select works to batch edit, go to Edit Selected, go back, deselect works and select new ones to batch edit, and go to Edit Selected, all works (deselected and newly selected) appear under "Changes will be applied to"

Actual behavior

When I select works to batch edit, go to Edit Selected, go back, deselect works and select new ones to batch edit, and go to Edit Selected, I expect only the newly selected works to appear under "Changes will be applied to"

Steps to reproduce the behavior

  1. Open Firefox or Safari (not Chrome)
  2. As a logged in user, go to "My Works"
  3. Select multiple works and click "Edit Selected" screen shot 2017-02-02 at 1 07 38 pm
  4. Note the works that appear under "Changes will be applied to" screen shot 2017-02-02 at 1 08 04 pm
  5. Click "Back" in your browser
  6. Deselect the selected works and select different works screen shot 2017-02-02 at 1 08 18 pm
  7. Click "Edit Selected"
  8. Note the works that appear under "Changes will be applied to" screen shot 2017-02-02 at 1 08 30 pm
mjgiarlo commented 7 years ago

Comment by mjgiarlo Friday Feb 03, 2017 at 15:59 GMT

Thanks for writing up this ticket, @hannahlwang, and I can confirm this is still an issue over in Hyrax. We're going to be radically reworking the batch edit functionality later this year in Hyrax, so I'm inclined to move this issue over to that codebase.

rjkati commented 3 years ago

This issue is still present in Hyrax 3.0.0 rc3 using Firefox 85.0. It only seems to occur when selecting works on the same page. When I select works on a different page, the correct works are selected.

jeremyf commented 3 years ago

@jlhardes Given that this works in Chrome but not Firefox nor Safari, I suspect there's going to be considerable time to reproduce and isolate this error.

The QA test finds it through the use of a Back action, which seems to be a low probability of happening in the wild.

What are your thoughts? Can we close this? Were I to estimate time expenditure to trap the error, I'd guess at least 3 hours (from me). Then to resolve, I'd imagine notably more.

jlhardes commented 3 years ago

This is a pretty specific set of actions to take and those steps don't cause a problem in every browser so there is something particular happening that seems to be also browser-specific. And based on your estimate of the amount of time it would take to narrow down the specific problems in Firefox and Safari I think I'll remove the 3.x milestone and put this into the Backlog for later (remove it from our current project board). There are other larger issues that need attention first.

eporter23 commented 1 year ago

Retested on Hyrax 3.5 with current Safari and Firefox (Mac). The behavior still exists in Safari, but seems resolved in Firefox.