ggeisler
commented
7 years ago @mjgiarlo @hannahfrost Proposed design below. There's a lot of explanation but my recommendation comes down to:
- Add the Registered Users group to the Depositor role for the default admin set only, when the app is first deployed
- Add a button labelled "Allow all registered users to deposit" (
btn-info btn-sm) just above the current Depositors table whenever that table does not include the Registered Users group. Clicking the button adds the Registered Users group to the Depositor role. - Hide that button whenever the Depositors table does include the Registered Users group
Details
I'll offer a couple of alternatives for the "widget" that enables the Admin Set Manager to easily open an admin set up for deposit: a button and a checkbox. I recommend the button version, because I unchecking the checkbox duplicates the Remove button functionality that is already there and I think that has the potential for confusion (and hiding a checkbox when it is in one state seems wrong to me).
Button Version
Two scenarios: the default admin set and non-default admin sets.
Default Admin Set
There's no need for the widget in this scenario because we'll assign the Registered Users group to the Depositor role by default. The Admin Set Manager can easily revoke that decision by clicking the Remove button.
If the Admin Set Manager does indeed remove the Registered Users group, the widget should appear as described below.
Non-Default Admin Sets
The Registered Users group is not added by default but because this could be a common goal for many admin sets, we want to make it easy and clear to the Admin Set Manager who wants to open the admin set up. So when the Registered Users group is not currently assigned to the Depositor role, we show a button:
(Note that this mockup assumes that ticket #429 is completed -- that's where the No depositors have been added to this administrative set line comes from -- but I don't think that ticket is a blocker for this one; they can be done in either order.)
We would show the button in the same way for the default admin set if the Admin Set Manager has removed the Registered Users group.
I think we still want to show the button if other users have been added as Depositors:
But when the Admin Set Manager clicks this button to add the Registered Users group to the Depositor role, I think we should then hide the button, since it has no purpose in that state.
Alternative Widget
If we went with a checkbox instead of a button, and didn't hide it, it would look like this:
With that approach, the checkbox is acting as a toggle, which seems clear enough. But it also is potentially confusing because unchecking the checkbox does the same thing as the Remove button in the Registered Users row.
hannahfrost
mjgiarlo
Admin Sets are currently open by default, despite the fact that we've created a new role for depositing to Admin Sets. Admin Sets should instead be closed by default, with the ability for Admin Set Managers to open them up for deposit by all registered users (via some sort of widget -- design needed here -- in the new/edit forms).
Note: the Default Admin Set should remain OPEN by default, but should be able to be made closed via the above widget.
Cc: @hannahfrost @ggeisler