search

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
184 stars 124 forks source link

Deprecate FileSetsController#create #420

Closed tpendragon closed 6 years ago

tpendragon commented 7 years ago

The UI in Hyrax doesn't call this anymore, as far as I can tell.

no-reply commented 6 years ago

If we are deprecating this, we should do it sooner rather than later.

RudyOnRails commented 6 years ago

We are scheduled to build an API endpoint here where our imaging department's order management software can send a request with an asset/work uuid and some params, and add a new file_set to a work. I plan to utilize CurationConcerns::FileSetsControllerBehavior#create. But, when we migrate from Sufia 7.2 to Hyrax 2.1 in the fall, would there be something else I could use since this ticket will most likely be completed?

Ah crud, it's already done: https://github.com/samvera/hyrax/commit/a4b7c8eb0d22583d003a8fa1d2422a8669dbd715#diff-f4e3b432213aa3b40fa2bd3be564f63e

RudyOnRails commented 6 years ago

@no-reply as mentioned above it's already done here: https://github.com/samvera/hyrax/commit/a4b7c8eb0d22583d003a8fa1d2422a8669dbd715#diff-f4e3b432213aa3b40fa2bd3be564f63e

closing.