search

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
184 stars 124 forks source link

Feature test: collection new form - write feature tests for creating a new Hyrax::PcdmCollection #4590

Open elrayle opened 3 years ago

elrayle commented 3 years ago

Descriptive summary

Write feature tests for creating a new Valkyrie based collection (i.e., Hyrax::PcdmCollection) using the new collection form.

Rationale

Behavior for Valkyrie resource collections should be the same as for ActiveFedora based collections.

Expected behavior

Can create a new Hyrax::PcdmCollection using the new collection form.

Actual behavior

If actual does not match expected, open an issue with details about what actual happened and what was expected.

Steps to reproduce the behavior

  1. Write new feature tests.

Related work

I couldn't find a non-valkyrie version of these tests.

Same needs to be done for Editing collections.

no-reply commented 3 years ago

it seems like we're missing any feature tests for creating collections at all. perhaps focus is better placed there?

the user-facing behavior for collections shouldn't be any different, whatever model is used by the controller; (i.e. there's no way for the user to select a Valkyrie collection).

no-reply commented 2 years ago

did this get closed by dbaec488c0fc9570159b7f9809c9f6ad82e75e39 ?