search

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
184 stars 124 forks source link

View Collection Page list options styling #5630

Closed eporter23 closed 2 years ago

eporter23 commented 2 years ago

Descriptive summary

Hyrax 3 Blacklight 7/Bootstrap 4 work: when viewing the Admin/Dashboard view of a Collection, the options (List, Gallery, Masonry, etc.) to change the layout of the works list needs restyling.

Rationale

Design continuity with current Hyrax 3x series

Expected behavior

The view options should appear as a small set of buttons with a light background and no visible text label until a user hovers over the element. Sizing and margins for the thumbnail in the works list also need refinement for easier scanning.

Screen Shot 2022-05-26 at 11 39 28 AM Screen Shot 2022-05-26 at 11 42 38 AM

Actual behavior

Buttons appear with dark background, increased size, and text. The thumbnail is also oversized and butts up against the work title.

Screen Shot 2022-05-13 at 2 51 42 PM

Steps to reproduce the behavior

  1. Go to Dashboard > Collections
  2. Open a Collection with more than one work
  3. See the list view options layout

Related work

Link to related tickets or prior related work here.

eporter23 commented 2 years ago

@jlhardes new blacklight 7/bootstrap css issue

jlhardes commented 2 years ago

Testing locally with bl7boot4rails6 build, the background for the non-selected options is light but the selected option is still dark. Is there another place to update background color or is this the way it looks now? I am not sure if it is necessary for this to look exactly the way it did before so I am open to considering this issue done. @adamjarling or @mathewjordan do you have thoughts for this?

Screen Shot 2022-06-13 at 3 45 49 PM

adamjarling commented 2 years ago

@jlhardes I'll take a look

jlhardes commented 2 years ago

The View Collection Page list option buttons are updated in bl7boot4rails6 local testing. The end user search results list option buttons are still showing dark backgrounds on the selected button but that can be a separate issue. Closing this issue.