samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
183 stars 124 forks source link

Search results alternative layouts missing styling (Gallery, Masonry) - Bootstrap 4 #5721

Open eporter23 opened 2 years ago

eporter23 commented 2 years ago

Descriptive summary

Hyrax 3.x branches using Bootstrap 4 appear to have missing styling for non-list search result layouts.

Rationale

Design continuity and usability

Expected behavior

When a user clicks on one of the non-default layouts, the search results should be presented in an alternative way according to the design pattern for that layout option.

Gallery (nurax example)

Screen Shot 2022-06-22 at 12 51 00 PM

Masonry (nurax example)

Screen Shot 2022-06-22 at 12 51 11 PM

Slideshow (nurax example)

Screen Shot 2022-06-22 at 12 59 37 PM

Actual behavior

Thumbnails are missing, and content blocks are not well delineated from each other. The slideshow option is also missing guidance text above the thumbnails ("Select an image to start the slideshow"), and the modal window is unstyled.

Gallery

Screen Shot 2022-06-22 at 12 53 02 PM

Masonry

Screen Shot 2022-06-22 at 12 53 14 PM

Slideshow

Screen Shot 2022-06-22 at 12 58 52 PM

Steps to reproduce the behavior

  1. Go to the homepage and hit Go in the search box to produce a large results list
  2. In the search results page, click on one of the non-list options such as Gallery, Masonry, or slideshow and observe the layout

Related work

Link to related tickets or prior related work here.

rjkati commented 1 year ago

testing blocked by #5888

jlhardes commented 1 year ago

5888 is closed and this should be testable on nurax-dev

jlhardes commented 1 year ago

On nurax-dev with Hyrax 4 beta2, Gallery view is better (there are boxes around each item so better delineated) but thumbnails still missing.

Masonry view looks better and is all thumbnails like it was before.

Slideshow view seems to have better thumbnail view but still missing "Select an image to start the slideshow" instruction text.

rjkati commented 1 year ago

Retested on nurax-dev (hyrax 4.0.0.beta2) and behavior is still as described in https://github.com/samvera/hyrax/issues/5721#issuecomment-1293739008