samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
185 stars 124 forks source link

Determine what Storage adapter should support Version for `nurax-pg` #6234

Closed no-reply closed 1 year ago

no-reply commented 1 year ago

there's a need to test file version management as implemented in the Hyrax UI (cf. https://github.com/samvera/hyrax/issues/6211). nurax-pg currently uses the Valkyrie::Storage::Disk adapter, which does not support versions.

determine a path forward for supporting versions on nurax-pg. it's possible we'll want to test this by implementing versioning for the disk adapter, or it may be possible we want to avoid this and implement versioning in a more realistic context (e.g. using shrine).

as a secondary consideration, we may also want to factor in how our choices here will or won't support us when testing in (.koppie),


Some considerations:

tpendragon commented 1 year ago

Koppie uses Disk, nurax-pg is a different app.

Success Criteria

Someone decides which adapter nurax-pg uses. Is nurax-pg a real production installation that we recommend people install?

Answer the question: What storage adapter will nurax-pg run, and will it support versioning. @dlpierce we're looking for an authoritative answer here.

Questions to answer:

dlpierce commented 1 year ago

Someone decides which adapter nurax-pg uses. Is nurax-pg a real production installation that we recommend people install?

Nurax PG was set to use disk out of convenience, but that can change. It should be made representative of all the major hyrax features, file versioning included, and provide an example of how a site might be deployed.

Answer the question: What storage adapter will nurax-pg run, and will it support versioning.

Whichever adapter supports versioning so it can be demonstrated. Having a disk backed storage with versioning is likely attractive to implementers who don't need/want to use an object store, but I don't think nurax-pg needs to use a disk storage adapter necessarily.

rjkati commented 1 year ago

It is now possible to upload a new version of a fileset to pg.nurax. I am seeing an error message when uploading a new version that doesn't seem to affect functionality. Restoring also does not seem to work. I will open new tickets for these issues.