samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
182 stars 122 forks source link

Switches Depositor values from Creator to Depositor. #6780

Open bwatson78 opened 2 months ago

bwatson78 commented 2 months ago

Summary

Switches Depositor values from Creator to Depositor.

Type of change (for release notes)

Add an appropriate notes-* label to the PR (or indicate here) that classifies this change.

Choose from:

Detailed Description

Pulls the actual depositor of the Work object instead of the Creator. Creator would be an acceptable value in applications that would always consider the Creator of the Work to be the Depositor, but in archive applications using Hyrax, that's not the case.

@samvera/hyrax-code-reviewers

github-actions[bot] commented 2 months ago

Test Results

    9 files  ±0      9 suites  ±0   16m 49s :stopwatch: +11s 4 762 tests ±0  4 699 :white_check_mark: ±0  63 :zzz: ±0  0 :x: ±0  6 488 runs  ±0  6 425 :white_check_mark: ±0  63 :zzz: ±0  0 :x: ±0 

Results for commit 77f678af. ± Comparison against base commit d8f0e9c0.

This pull request removes 100 and adds 100 tests. Note that renamed tests count towards both. ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 2f9da4c2-e182-4d1b-a595-184d0b91cb45 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: eb5fe03e-ecab-43c7-85d0-79fa6d41bab1 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: f9f2378b-b532-4d8f-879a-408e5e60c0dd spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to destroy Hyrax::AdministrativeSet: d1c33524-be48-4748-b2ef-dee81075e403 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to edit Hyrax::AdministrativeSet: a100d498-c1b8-4e66-9cec-f1f1a7d79af6 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to update Hyrax::AdministrativeSet: a0220071-956a-4438-a83e-7b6dd373f24b … ``` ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: da5d68bf-23a7-4809-8826-3e9f80fe9357 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: b88afc26-8945-41bb-b990-49b2fb1caf14 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 3e4029b9-b1fa-4dae-959e-7b05ad40b744 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to destroy Hyrax::AdministrativeSet: a8d03002-d228-4e66-9b65-148afd251e4b spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to edit Hyrax::AdministrativeSet: 825ea21c-2130-43c7-80cb-c80f07534fef spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to update Hyrax::AdministrativeSet: 01eb3be3-43d3-4903-9ee4-c1e9439a8136 … ```