Closed laritakr closed 1 month ago
9 files ±0 9 suites ±0 17m 34s :stopwatch: +20s 4 763 tests +1 4 700 :white_check_mark: +1 63 :zzz: ±0 0 :x: ±0 6 489 runs +1 6 426 :white_check_mark: +1 63 :zzz: ±0 0 :x: ±0
Results for commit 4623c640. ± Comparison against base commit 943b0027.
:recycle: This comment has been updated with latest results.
@dlpierce I believe I've addressed your feedback requests. Everything passed except that flaky 'email' test.
Valkyrie derivatives sort of work but only by accident. We need to access them via the storage adapter, rather than assuming we will find them on the file system. This begins the process of accessing derivatives appropriately.
The idea is to always include the options to download derivatives on the actions dropdown.
The actions download menu does not have a Hyrax::FileSet object... it has a Hyrax::IiifAv::IiifFileSetPresenter object (at least when we are using IiifPrint). The
extensions_and_mime_types
method we added to the fileset gives us an array of hashes that we can use for the actions dropdown:Screenshots
![Screenshot 2024-05-15 at 4 42 42 PM](https://github.com/samvera/hyrax/assets/17851674/d94317a4-4988-4413-8658-4224af361ded) ![Screenshot 2024-05-15 at 4 42 51 PM](https://github.com/samvera/hyrax/assets/17851674/810e146c-97b5-481d-854b-943d843c2ebd)