search

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
182 stars 122 forks source link

Find count by fix #6819

Closed orangewolf closed 1 month ago

orangewolf commented 1 month ago

Fixes

find_count_by only worked for Postgres backed models, not for all adapters.

@samvera/hyrax-code-reviewers

github-actions[bot] commented 1 month ago

Test Results

    1 files   -     8      1 suites   - 8   0s :stopwatch: - 16m 41s     2 tests  - 4 757      0 :white_check_mark:  - 4 696  0 :zzz:  - 63  2 :x: +2  1 733 runs   - 4 758  1 731 :white_check_mark:  - 4 697  0 :zzz:  - 63  2 :x: +2 

For more details on these failures, see this check.

Results for commit 6b989a6e. ± Comparison against base commit 4d2c654a.

This pull request removes 4759 and adds 2 tests. Note that renamed tests count towards both. ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 9591d9c7-9508-4ffd-b2be-f57a55ae9895 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: efbb557d-140f-4a84-bab1-216093f8aca0 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 476c198b-b1ef-41f1-b058-74449b22d305 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin #admin? is true spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to destroy Hyrax::AdministrativeSet: 38c0fa8d-3525-43af-bd71-457c16642117 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to edit Hyrax::AdministrativeSet: 691e909d-0a0a-448e-82fe-24e1b880f739 … ``` ``` app.services.hyrax.custom_queries.find_count_by ‑ Style/NegatedIf lib.freyja.query_service ‑ Layout/EmptyLineBetweenDefs ```