samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
184 stars 124 forks source link

Add admin set selection to worktype modal #6829

Closed laritakr closed 3 months ago

laritakr commented 3 months ago

Summary

SoftServe is working to add another metadata schema option similar to AllinsonFlex as a Hyrax option. To support flexible metadata, an admin set needs to be selected along with a work type in order to find the appropriate attributes for the form.

Changes proposed in this pull request:

Screenshots ### With the ability to assign to an admin set ![Screenshot 2024-06-06 at 8 08 15 PM](https://github.com/samvera/hyrax/assets/17851674/3802568a-4432-4f85-ae17-80c05175a266) ### Without the ability to assign to an admin set ![Screenshot 2024-06-06 at 8 07 28 PM](https://github.com/samvera/hyrax/assets/17851674/89af2c07-5b8e-4ae7-9c77-702a7a9bcb2a)

Notes

Note that this does not address the ability to change an admin set on a work on the relationships tab. The ability to change admin set is problematic (what happens if you change from an admin set with mediated deposit to one without?) but if the metadata options are contingent on an admin set, this option cannot be allowed.

Additional translations need to be added for languages other than English.

@samvera/hyrax-code-reviewers

github-actions[bot] commented 3 months ago

Test Results

    17 files  ±0      17 suites  ±0   2h 20m 39s :stopwatch: + 2m 16s  6 704 tests ±0   6 407 :white_check_mark: ±0  297 :zzz: ±0  0 :x: ±0  13 175 runs  ±0  12 780 :white_check_mark: ±0  395 :zzz: ±0  0 :x: ±0 

Results for commit 38b6f349. ± Comparison against base commit c9241b1a.

This pull request removes 265 and adds 265 tests. Note that renamed tests count towards both. ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 17bb2cd0-cc2c-4cd3-85fe-67b2e0f84045 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 108ec0fa-e6b6-4ba0-8551-7308b29097ee spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 65bbfb85-fde2-4f86-871f-09e1f64befa1 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: efdd67c4-cfc1-4476-8f07-96eeae136360 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 18bc05d2-ac47-4620-8346-2d694c8eae85 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 858e6e7b-45eb-4af6-908a-5a0408f64260 … ``` ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: ce3a7347-4bbb-463f-8a41-e398774e9798 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: ce22628d-e7a3-454d-b062-4bbe877ca4ec spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 92bf2d41-36a9-46e2-9ca3-03eea80e5578 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 6c3b47be-0a44-4d74-a4cf-e9d3603a3540 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 94fbabfe-eadd-4c5a-a2e8-60c3c32995cb spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 15a08568-4f5f-404b-a36c-13c188a11b97 … ```

:recycle: This comment has been updated with latest results.