samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
182 stars 122 forks source link

Metadata profiles UI #6835

Closed kirkkwang closed 3 weeks ago

kirkkwang commented 3 weeks ago

Fixes

Fixes #issuenumber ; refs #issuenumber

Summary

Present tense short summary (50 characters or less)

Guidance for testing, such as acceptance criteria or new user interface behaviors:

*

Type of change (for release notes)

Add an appropriate notes-* label to the PR (or indicate here) that classifies this change.

Choose from:

Detailed Description

More detailed description, if necessary. Try to be as descriptive as you can: even if you think that the PR content is obvious, it may not be obvious to others. Include tracebacks if helpful, and be sure to call out any bits of the PR that may be work-in-progress.

Description can have multiple paragraphs and you can use code examples inside:

class PostsController
  def index
    respond_with Post.limit(10)
  end
end

Changes proposed in this pull request:

*

@samvera/hyrax-code-reviewers

github-actions[bot] commented 3 weeks ago

Test Results

    1 files   -     8      1 suites   - 8   0s :stopwatch: - 16m 41s     6 tests  - 4 753      0 :white_check_mark:  - 4 696  0 :zzz:  - 63  6 :x: +6  1 742 runs   - 4 749  1 736 :white_check_mark:  - 4 692  0 :zzz:  - 63  6 :x: +6 

For more details on these failures, see this check.

Results for commit bdaa9ee0. ± Comparison against base commit 4d2c654a.

This pull request removes 4759 and adds 6 tests. Note that renamed tests count towards both. ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 9591d9c7-9508-4ffd-b2be-f57a55ae9895 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: efbb557d-140f-4a84-bab1-216093f8aca0 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 476c198b-b1ef-41f1-b058-74449b22d305 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin #admin? is true spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to destroy Hyrax::AdministrativeSet: 38c0fa8d-3525-43af-bd71-457c16642117 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates as admin behaves like A user with additional access is expected to be able to edit Hyrax::AdministrativeSet: 691e909d-0a0a-448e-82fe-24e1b880f739 … ``` ``` app.controllers.hyrax.metadata_profiles_controller ‑ Layout/IndentationConsistency app.controllers.hyrax.metadata_profiles_controller ‑ Layout/IndentationWidth app.controllers.hyrax.metadata_profiles_controller ‑ Metrics/MethodLength app.controllers.hyrax.metadata_profiles_controller ‑ Style/RedundantReturn app.models.hyrax.flexible_schema ‑ Style/RedundantSelf lib.wings.active_fedora_converter ‑ Metrics/AbcSize ```