search

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
184 stars 124 forks source link

Fix Add Child link #6837

Closed kirkkwang closed 3 months ago

kirkkwang commented 3 months ago

Summary

The links under the Add Child dropdown was not working because the HTML structure was not correct. This commit will close the button tag and then open the ul tag which allows the links to be clickable.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

Type of change (for release notes)

https://github.com/samvera/hyrax/assets/19597776/e076db13-4fec-478b-9e69-90ef179397f6

@samvera/hyrax-code-reviewers

github-actions[bot] commented 3 months ago

Test Results

    17 files  ±0      17 suites  ±0   2h 20m 17s :stopwatch: + 1m 54s  6 704 tests ±0   6 407 :white_check_mark: ±0  297 :zzz: ±0  0 :x: ±0  13 175 runs  ±0  12 780 :white_check_mark: ±0  395 :zzz: ±0  0 :x: ±0 

Results for commit 820a76a2. ± Comparison against base commit c9241b1a.

This pull request removes 266 and adds 266 tests. Note that renamed tests count towards both. ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 17bb2cd0-cc2c-4cd3-85fe-67b2e0f84045 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 108ec0fa-e6b6-4ba0-8551-7308b29097ee spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 65bbfb85-fde2-4f86-871f-09e1f64befa1 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: efdd67c4-cfc1-4476-8f07-96eeae136360 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 18bc05d2-ac47-4620-8346-2d694c8eae85 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 858e6e7b-45eb-4af6-908a-5a0408f64260 … ``` ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 84143984-7129-4620-b0bf-9eb27779788d spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 924ac671-812d-4e31-86f4-e957579d43fe spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 59e32f95-d2d4-4c3e-8cfc-999005bb58f5 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 336f4778-4885-4e71-9596-a041cb3a00a5 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: a1ffeb83-92c8-49ca-b3c1-3bd3f7cb02e6 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 66065086-17c6-44d6-a9a6-c0bcb3cc3b6c … ```

:recycle: This comment has been updated with latest results.