samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
184 stars 124 forks source link

Some frontend updates #6847

Closed kirkkwang closed 3 months ago

kirkkwang commented 3 months ago

Summary

This PR proposes a number of small UI discrepancy fixes, mostly css changes.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

Type of change (for release notes)

I believe these are notes-bugfix and Needs UX review.

Detailed Description

Make pagination adjust at an earlier width

88e9fa9e17255e7e30493b4700a14bb323704497

The pagination links on the catalog results page were getting really squished so this commit will make it move up above the sorting controls at an earlier width.

https://github.com/samvera/hyrax/assets/19597776/38c5e425-197a-4d7e-8440-fd6ffdec760a

Bring back hamburger menu on the top right

ec467bdb984e4dd7496c3ac21aa1aaf5595bff23

This commit will remove a button that appears on the facets at a certain width that, as far as I can tell, doesn't seem to do anything at the moment. I think it's supposed to open and collapse the all the facets. Consider bringing it back if the functionality is needed/fixed.

https://github.com/samvera/hyrax/assets/19597776/b8050542-9b33-42df-9e9e-09731cc6089a

Make pagination colors same as primary color

e9749b25e4da5cb5d77b7524d3976cd43e4bc048

The pagination colors were still default and doesn't match anything. This commit will couple it with the primary button color.

https://github.com/samvera/hyrax/assets/19597776/e5551cdd-e69c-4c54-8da1-9c31cd655dba

Break long links in catalog search

c921f7fc16b9457092ec32aa605301d980d8f14d

This will make any long links break. Prior to this commit any links that didn't have a - or a character that would create a natural word break would push the UI until it looked weird.

https://github.com/samvera/hyrax/assets/19597776/18d832b8-b874-44ad-853b-43ab6602a4c5

Make new/edit works form labels bold

356fbb456fc6df2e3cf48c35b7b310cd2554d3d0

In the new/edit works form, the labels used to be bold, but they are not anymore. This commit will make it bold again.

https://github.com/samvera/hyrax/assets/19597776/e62296ae-64e4-4098-8025-d1ca4cb5a432

@samvera/hyrax-code-reviewers

github-actions[bot] commented 3 months ago

Test Results

    17 files  ±0      17 suites  ±0   2h 17m 24s :stopwatch: - 4m 38s  6 705 tests ±0   6 408 :white_check_mark: ±0  297 :zzz: ±0  0 :x: ±0  13 178 runs  ±0  12 783 :white_check_mark: ±0  395 :zzz: ±0  0 :x: ±0 

Results for commit 821008f9. ± Comparison against base commit 3083b6f3.

This pull request removes 266 and adds 266 tests. Note that renamed tests count towards both. ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 6e7a3852-6b50-4c25-987c-47e671abb158 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 83c8b6f7-d611-41cb-8401-360f157db17b spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: bc76516c-3be9-47df-8cb9-06334c7dc7d7 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 45aacd8b-f55e-4e6f-bd34-ba311c7ecbd5 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 3ae63dfb-e841-4e61-8930-9e44253dddb7 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 205950bb-1207-4f73-a2af-e951c319dcb1 … ``` ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: d5755560-cfc0-4fa2-97cf-206206854730 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 417c5595-adb7-4de7-b58d-94a4f797f013 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 2775a378-75b8-4b89-8877-a44bbebc8216 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: a7b5d661-6ed4-47da-b98f-49ec3ba53c4f spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 40e04883-b2c0-4e02-ab45-571d6e4a785c spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 8c949b4d-d443-42b1-82b3-beffef5da735 … ```

:recycle: This comment has been updated with latest results.