Open bwatson78 opened 1 month ago
This seems to address the symptom of a bigger problem, likely where an unsaved object with a nil id is associated with this parent object via an *_id*
field, and to_s
is called on that nil for compatibility reasons (because it's presumed to be a Valkyrie::ID) and then the resulting empty string gets persisted.
17 files ±0 17 suites ±0 2h 19m 29s :stopwatch: + 4m 54s 6 706 tests +2 6 409 :white_check_mark: +3 297 :zzz: ±0 0 :x: - 1 13 180 runs +2 12 785 :white_check_mark: +3 395 :zzz: ±0 0 :x: - 1
Results for commit ff1a22c5. ± Comparison against base commit e4f8a06a.
Fixes
Fixes #6874
Summary
Cleans ID array attributes before persisting with pair-tree Valkyrie Fedora.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Failed save on # undefined method split' for nil:NilClass
should not appear, replaced with a success message.Type of change (for release notes)
notes-bugfix
Bug Fixesnotes-valkyrie
Valkyrie ProgressChanges proposed in this pull request:
sync
ing, where instances ofValkyrie:ID
with empty ID values could be created.@samvera/hyrax-code-reviewers