samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
185 stars 124 forks source link

Fix subtle background gradient on featured works #6893

Closed kirkkwang closed 3 months ago

kirkkwang commented 3 months ago

Summary

The gradient was throwing an invalid property value error which should be fixed now.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

Type of change (for release notes)

Before

image

After

image

@samvera/hyrax-code-reviewers

github-actions[bot] commented 3 months ago

Test Results

    17 files  ±0      17 suites  ±0   2h 16m 58s :stopwatch: +21s  6 706 tests ±0   6 409 :white_check_mark: ±0  297 :zzz: ±0  0 :x: ±0  13 180 runs  ±0  12 785 :white_check_mark: ±0  395 :zzz: ±0  0 :x: ±0 

Results for commit e9e360f1. ± Comparison against base commit 69f0b81f.

This pull request removes 273 and adds 273 tests. Note that renamed tests count towards both. ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 88744f00-2673-43d6-a8bf-efafa5395752 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: cb866d41-6d87-437f-99af-1101ce781f8a spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: b2b20d31-8376-418d-a189-d46a9fac4140 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: ccb398e0-6fdd-4589-80a0-faaef6085a03 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 3d638d81-f4b5-4c8f-8cab-5947edd776c1 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 5f17f912-b947-479a-8099-10c1b6f1bfd9 … ``` ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: f6b2bfe9-dd6b-477e-acc6-a034a9a47fb0 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 04ad0b32-9aa3-477e-8197-288039053a53 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a8a05b8b-81a5-403b-ae12-cc6f25998f9c spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 770f12a4-5469-41ea-8a6c-01583f18dce5 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 10363ff6-3e3e-4a48-b581-1e259bf13006 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 5c715bee-2463-4d09-a0b7-b00b430fa445 … ```