search

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
185 stars 124 forks source link

Adding alt attribute on thumbnail in search results list view #6911

Closed jlhardes closed 2 months ago

jlhardes commented 2 months ago

Fixes

Fixes #6749 - This adds alternative text on thumbnails in the search results list view but not on the gallery or masonry views. Those views currently have empty alt attributes and are passing accessibility test via SiteImprove but are not actually providing any alternative text.

Summary

Calling up work title and using that for alternative text attribute value

Type of change (for release notes)

@samvera/hyrax-code-reviewers

jlhardes commented 2 months ago

Also addresses #6891 (same report using WAVE instead of SiteImprove)

github-actions[bot] commented 2 months ago

Test Results

    17 files  ±0      17 suites  ±0   2h 16m 53s :stopwatch: +18s  6 706 tests ±0   6 409 :white_check_mark: +1  297 :zzz: ±0  0 :x:  - 1  13 180 runs  ±0  12 785 :white_check_mark: +1  395 :zzz: ±0  0 :x:  - 1 

Results for commit 36b4120b. ± Comparison against base commit e4886f1e.

This pull request removes 273 and adds 273 tests. Note that renamed tests count towards both. ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 44f92cfc-02b8-4e52-8c30-c00fd19bfdd7 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 81c62b64-8048-4b86-8eb4-198eb8bc1fe1 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a725e3af-48a9-4fe7-a1dc-5a6c1444088f spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 0cfada86-f26e-4fd4-b65a-15c3b1926af0 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: a8a7a7b7-b461-48cf-b4d8-f5854af674f9 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 1ad8889c-a2ff-48b9-8d97-18ad577b7a12 … ``` ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: d000e8d2-cd92-4211-852a-8f2adbe76234 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 7dca803e-0350-4252-ae24-6e3d08fff48d spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 0a8e6ea9-993b-4216-bd63-948b25bb51d0 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 8114fa21-7055-41df-9dda-c8bb7c342c66 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 06b83772-fbf5-4e1d-8d28-636a1e6271b9 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 27b78c42-4132-49d8-8383-98343478918c … ```

:recycle: This comment has been updated with latest results.