WIP Bootstrap 5 - Githubissues

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.

http://hyrax.samvera.org/

Apache License 2.0

185 stars 124 forks source link

WIP Bootstrap 5 #6912

Open dlpierce opened 1 month ago

dlpierce commented 1 month ago

Fixes

Fixes #6904

Summary

Upgrade to Bootstrap 5

Guidance for testing, such as acceptance criteria or new user interface behaviors:

Website loads with no major layout style issues

Changes proposed in this pull request:

Update to Bootstrap 5 framework, modifying JS and SCSS as needed.

dlpierce commented 1 month ago

Currently blocked by changes needed in Browse Everything:

SassC::SyntaxError: Error: The target selector was not found. (SassC::SyntaxError)
db_migrate-1  |        Use "@extend .mr-2 !optional" to avoid this error.
db_migrate-1  |         on line 73 of ../../bundle/ruby/3.2.0/gems/browse-everything-1.3.0/app/assets/stylesheets/browse_everything/_browse_everything_bootstrap4.scss
db_migrate-1  | >>       @extend .mr-2;

github-actions[bot] commented 1 month ago

Test Results

0 files - 17 0 suites - 17 0s :stopwatch: - 2h 23m 27s 0 tests - 6 705 0 :white_check_mark: - 6 407 0 :zzz: - 297 0 :x: - 1 0 runs - 13 180 0 :white_check_mark: - 12 784 0 :zzz: - 395 0 :x: - 1

Results for commit d3f70314. ± Comparison against base commit aeb5e3e5.

:recycle: This comment has been updated with latest results.