samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
185 stars 124 forks source link

Lazy migrate characterization along with file #6914

Closed laritakr closed 1 month ago

laritakr commented 1 month ago

Fixes

When migrating file_sets, the actual file is currently transfering, but file characterization data is getting lost. This fix prevents the file characterization data (such as height and width) from going missing after saving to Postgres or Fcrepo 6 from a perviously saved Fcrepo 4 object.

Changes proposed in this pull request:

[1] - Both of these two points are things we have been putting in all the config/initializer/wings.rb files when we enable Freyja. In order to get specs working for this migration issue, we needed to pull them in to Hyrax. It seemed better to make the included instead of duplicating the logic in the spec helpers.

github-actions[bot] commented 1 month ago

Test Results

    17 files  ±0      17 suites  ±0   2h 17m 38s :stopwatch: - 3m 25s  6 707 tests +1   6 410 :white_check_mark: +2  297 :zzz: ±0  0 :x:  - 1  13 183 runs  +3  12 787 :white_check_mark: +3  396 :zzz: +1  0 :x:  - 1 

Results for commit 003e122d. ± Comparison against base commit f77472d5.

This pull request removes 274 and adds 275 tests. Note that renamed tests count towards both. ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 5df7d499-6552-4102-a913-86d67630c8ea spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 8eadeeb8-f856-4737-8542-0bdf7aabe98d spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: f6496b1c-b929-4fa3-ab68-b84844f3e73b spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 634b6383-85a4-4961-b70a-2d896515ab43 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 3a4668fc-88bf-437c-b4da-278ff5853330 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: e08b6f6a-c456-4f0c-8df3-78bae20aeccf … ``` ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: e635d2cb-c7f8-4f9f-a942-326ad2560fab spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: acd3afae-b5c7-4bf7-b093-c3b02af3d048 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 32d1932d-6239-4297-9a75-8fd6b74b7869 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 94df5579-c67f-4a6d-a960-0f24619e3316 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 1a650506-81c7-4202-bf97-03fd846b719f spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 855af1ae-9f2f-4009-bb19-342bbc71694b … ```

:recycle: This comment has been updated with latest results.