search

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
185 stars 124 forks source link

Always save nonpersisted ACLs #6930

Closed dlpierce closed 2 weeks ago

dlpierce commented 1 month ago

Summary

Calling save on a new (unpersisted) ACL object should persist it even when there are no changes otherwise.

github-actions[bot] commented 1 month ago

Test Results

    17 files  ±0      17 suites  ±0   2h 16m 4s ⏱️ - 2m 4s  6 731 tests +3   6 434 ✅ +3  297 💤 ±0  0 ❌ ±0  13 233 runs  +4  12 833 ✅ ±0  400 💤 +4  0 ❌ ±0 

Results for commit 62aaf98a. ± Comparison against base commit 43658854.

This pull request removes 267 and adds 270 tests. Note that renamed tests count towards both. ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: e34a15f9-8562-4479-814f-6ff8dd333fc3 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: c541d60a-0e9f-49cd-b973-ebabc7a2244f spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: b1664473-e5bf-465b-b438-05c3dc183bc9 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 93867d41-2935-45ff-8e1f-a5dd9e234e52 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 7dbaaf6b-4cf9-45a4-88d4-96c98710f860 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 7659bef5-2d41-4920-96ff-671a4d476a10 … ``` ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: afb77574-2f9e-4f16-bebe-e281b8a5ed68 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 1bf011ce-34db-4810-aefd-0371bc4df369 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 39c5d92d-ab68-4efe-903c-e63fe77f1f60 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 397e2d5a-0e65-45ff-aca5-8b6931d58bc2 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 0b58a039-6266-4c6a-9ea3-cd7cfb103e7c spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 6c64c685-ce8c-4896-8cd6-4704b65b4c6d … ```

:recycle: This comment has been updated with latest results.