samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
184 stars 124 forks source link

Running the workflow rake task doesn't set the Default workflow in the Default Admin Set #897

Closed bmquinn closed 7 years ago

bmquinn commented 7 years ago

Descriptive summary

Ran into an issue during our Sufia 7.3 > Hyrax upgrade. After running rake curation_concerns:workflow:load we ran into an issue where the "Default workflow" was not set for the Default Admin Set. Possibly due to an ordering issue, our Admin Set was created prior to loading the workflows if I recall correctly. In the screenshot below, neither option was selected for the Default workflow. This issue was easily solved by checking the radio button for the Default workflow in the admin interface and saving.

Expected behavior

default_workflow
mjgiarlo commented 7 years ago

@bmquinn I'm wondering how I might reproduce this. I tried generating a new Hyrax 1-0-stable instance and the checkbox is selected. So the issue pops up when you create the Default AS and load works and then upgrade to Hyrax? If so, maybe we "fix" this by adding a line to the release notes saying "go to the AS UI and check the box like @bmquinn did?"

mjgiarlo commented 7 years ago

(Which I've now done.)

hackartisan commented 7 years ago

I think the fix is to reorder the operations in the README; put the workflow loading rake task before the default admin set task.

However, I believe if you install via template it does the workflow load for you, so in that instance that step would be optional.

jcoyne commented 7 years ago

@hackmastera can you confirm that and add documentation as to why it has to be that way?

mjgiarlo commented 7 years ago

@hackmastera Might you have cycles for :point_up:? Alternatively, given the discussion above, I wonder if we might close this issue? cc: @bmquinn

hackartisan commented 7 years ago

could not reproduce on hyrax 1.0.0.rc2

mjgiarlo commented 7 years ago

Thx! (Feel free to re-open if closed too hastily.)