Closed kirkkwang closed 1 year ago
Currently if conditions are not met, #populate_rendering returns an empty array which makes the rendering appear in the manifest as such. I propose to remove rendering from the manifest if it is empty so it can be cleaner.
#populate_rendering
rendering
manifest.rendering
PerceivedComplexity
@cjcolvar Apparently, be_false and be_true have changed to be_falsey and be_truthy 🤷
be_false
be_true
be_falsey
be_truthy
I used be false since it was used elsewhere already, let me know if you want it as be_falsey
be false
Anyway, thanks for the suggestion, tests pass on this now!
A proposed change
Currently if conditions are not met,
#populate_rendering
returns an empty array which makes therendering
appear in the manifest as such. I propose to removerendering
from the manifest if it is empty so it can be cleaner.manifest.rendering
#populate_rendering
PerceivedComplexity