search

samvera / iiif_manifest

Other
10 stars 10 forks source link

Add supplementing annotations to canvas #96

Closed masaball closed 1 year ago

masaball commented 1 year ago

This PR adds builders for the V3 manifest to facilitate creating annotations for supplementing content, most specifically A/V caption/subtitle and transcript content.

masaball commented 1 year ago

I think that DisplayContent and SupplementingContent are conceptually different enough that it makes sense to have separate classes for each. If we were to keep it as a single handler, I think we should rename it from DisplayContent to something more generic.

You have a good point that the SupplementingBodyBuilder is only adding a single additional field over what BodyBuilder supplies, and I think the purpose is, effectively, the same conceptually. It is building the body of the annotation. So I can get behind trying to rework BodyBuilder and avoid the duplication with SupplementingBodyBuilder.