search

samvera / ldp

Linked Data Platform.rb client
Other
16 stars 15 forks source link

fix overwrite of HTTP headers #38

Closed lasse-aagren closed 9 years ago

lasse-aagren commented 9 years ago

such that downstream consumer added headers (e.g. basic auth) don't dissapear

jcoyne commented 9 years ago

@lasse-aagren I'm not sure that any of this work is necessary. Take a look here:

https://github.com/cbeer/ldp/compare/basic_auth

Faraday adds basic auth headers at the very last moment. I don't think it's possible to overwrite them.

lasse-aagren commented 9 years ago

@jcoyne well, fact is that it works with, and doesn't without this work :)

edit: seen from my version of active-fedora with basic_auth

2nd edit: wether I put http://username:password@fedorahost:8080/rest in fedora.yml, or use Faraday's basic_auth in the code, these headers dissapear, unless something like this is applied

jcoyne commented 9 years ago

@lasse-aagren can you write a test to demonstrate that? It's important we have a test so that someone doesn't inadvertently revert your changes in the future.

lasse-aagren commented 9 years ago

@jcoyne I've pushed a test

jcoyne commented 9 years ago

@lasse-aagren this is looking good. Can you squash your commits? @cbeer can you give feedback?

lasse-aagren commented 9 years ago

squashed

lasse-aagren commented 9 years ago

anything else I should do?

jcoyne commented 9 years ago

I'm just waiting for @cbeer to weigh in.

lasse-aagren commented 9 years ago

any chance this will happen?

cbeer commented 9 years ago

:+1: