search

samvera / ldp

Linked Data Platform.rb client
Other
16 stars 15 forks source link

Resource should not send weak ETag in If-Match for delete or update #64

Closed dchandekstark closed 7 years ago

dchandekstark commented 8 years ago

Currently, LDP::Resource unconditionally adds an If-Match header to delete and update requests with the ETag from a previous GET, if available. It should not add this header if the ETag is weak b/c HTTP PUT and DELETE require strong comparison when If-Match is present.

See also: https://github.com/fcrepo4/fcrepo4/pull/1089

/cc @escowles

escowles commented 7 years ago

We discussed this back in August, and decided the best thing to do was for the client to use If-Unmodified-Since instead of If-Match.

cjcolvar commented 7 years ago

This currently breaks fedora-migrate for fedora 4.6.0+.

cjcolvar commented 7 years ago

Fedora ticket suggesting If-Unmodified-Since instead of If-Match: https://jira.duraspace.org/browse/FCREPO-2122