search

samvera / ldp

Linked Data Platform.rb client
Other
16 stars 15 forks source link

Don't bother doing a HEAD request to see if the object is new #81

Closed jcoyne closed 7 years ago

jcoyne commented 7 years ago

If it is new, we'll get the data and have avoided a HEAD request. We just need to handle a 404, when it doesn't exist.

This results in a 27% decrease in HEAD requests in the ActiveFedora create a work with access controls use case.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 4311d2a27a12d249cbc3a64b1c9e61c31f2b53e5 on optimization into on master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 4311d2a27a12d249cbc3a64b1c9e61c31f2b53e5 on optimization into on master.

awead commented 7 years ago

👍 but, what about the 404 case? If I'm trying to request something that should be there, but isn't, how do I tell the difference?

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 04e44963e7d7d568d1198f721a2252a3f10e41e3 on optimization into on master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 04e44963e7d7d568d1198f721a2252a3f10e41e3 on optimization into on master.

jcoyne commented 7 years ago

@awead this has no difference from the current behavior in that case.