search

samvera / questioning_authority

Question your authorities
Other
54 stars 30 forks source link

remove obsolete URL processing methods #193

Closed elrayle closed 5 years ago

elrayle commented 5 years ago

Ref PR #187 Create models for IRI templates and use IRI template service to build URLs

When IriTemplateService was created, several methods in the config files became obsolete, but didn't get removed as part of that PR.

elrayle commented 5 years ago

PR #194 which updates the Travis ruby matrix needs to be merged to get the tests passing in this and all future PRs.

carolyncole commented 5 years ago

@elrayle this one looks ok, except the coverage went down on your configurations. You may need to add some tests just for those. Also Travis is acting strange in a few builds, but I do not think that is isolated to this PR. I have heard a couple people in the office mention travis and bundler.

elrayle commented 5 years ago

Turns out there are a few more methods that are also obsolete causing test coverage to go down. Nice when the tools help us to find issues. I'm in the process of removing the additional obsolete methods now.