Replace URI.escape with ERB::Util.url_encode

[elrayle]

This is the closest replacement to what already exists. There are multiple discussions on what is the correct way to do this. We may want to revisit later.

See… https://stackoverflow.com/questions/2824126/whats-the-difference-between-uri-escape-and-cgi-escape

This addresses deprecation warnings associated with URI.escape

[elrayle]

This is related to the work done in PR #196.

[elrayle]

Confirmed each modified authority by comparing results before and after for the following URLs...

• http://localhost:3000/qa/search/assign_fast/all?q=periodic+table
• http://localhost:3000/qa/search/crossref/journals?q=chest
• http://localhost:3000/qa/search/geonames?q=port
• http://localhost:3000/qa/search/getty/aat?q=amphora
• http://localhost:3000/qa/search/getty/tgn?q=memphis
• http://localhost:3000/qa/search/getty/ulan?q=washington
• http://localhost:3000/qa/search/loc/subjects?q=History--
• http://localhost:3000/qa/search/linked_data/oclc_fast?q=twain&maximumRecords=10

[elrayle]

This replaces PR #196 which made a fix for a single authority. This makes a consistent fix across all uses of URI.escape.

NOTE: The use of ERB::Util.url_encoding was selected as the replacement for two reasons... 1) It was already in use in other places in the code, so use in this case provided consistency. 2) The original suggestion of CGI.escape produces a different URL using + instead of %20 for spaces and other similar differences in substitution. These differences may or may not have an impact on the results.

[elrayle]

@bbarberBPL As this replaces PR #196, can you review and comment on the changes in this PR?

[elrayle]

I tried before and after for...

• http://localhost:3000/qa/search/loc/names?q=Queer%20as%20folk%20(Television%20program%20:%20U.S.)
• http://localhost:3000/qa/search/loc/names?q=King%20Cole%20of%20Spokane,%20Inc.

Both worked in the before and after tests.

[elrayle]

@hackmastera You appear to be the original committer for assign_fast. There is a question about the clean_query_string method for assign_fast. The call to URI.escape is being replaced by ERB::Util.url_encode. The original code includes a gsub that appears to remove some characters. With ERB::Util.url_encode, these characters appear to be encoded properly. I am wondering two things...

• Is the new approach adequate and the gsub can be removed?
• Do you have an example that requires the gsub that can be used for before and after testing?

[hackartisan]

@elrayle It looks like assign_fast is still in use in https://github.com/sciencehistory/chf-sufia/blob/master/app/assets/javascripts/edit_metadata.js; maybe @jrochkind or @eddierubeiz could identify some tests?

My vague memory is that the characters I removed were an issue on the API side, rather than a matter of encoding.