search

samvera / questioning_authority

Question your authorities
Other
54 stars 30 forks source link

refactor optional attributes for linked data search/fetch to pass as hash #279

Closed elrayle closed 4 years ago

elrayle commented 4 years ago

The list of parameters that are passed to search and find methods for the linked data module are long. There is a need to add another parameter. In prep for that, this refactors the optional parameters into a single request_header parameter. This same change is also in AuthorityUrlService which builds the URLs used in search and find and is the primary consumer of the optional params.

All other changes are in the callers of these methods, which is coming from LinkdedDataTermsController actions.

The longer individual parameter lists are deprecated.

elrayle commented 4 years ago

@geekscruff Thanks for the review. I added in a comment about deprecation of individual parameter above each of the build_request_header methods.